Post
Topic
Board Announcements (Altcoins)
Re: [ANN][DASH] Dash | First Anonymous Coin | Inventor of X11, DGW, Darksend and InstantX
by
Limx Dev
on 02/05/2015, 14:34:43 UTC
I was holding off on dropping a new Windows wallet build until I could include the escrow manager.  If you want a build sooner let me know, I can do one with the I2P stuff.  The code is already up in github.

The issue with darksend is that there is a hardcoded collateral address in there, which I find a little scary.  I want to look at it and evaluate it before making that stuff visible in the UI again.

jase there are a couple of ways to achieve connection encryption like that.  We use something like that under the hood for the escrow orchestration and market infrastructure.


Glad other devs are finally addressing this, havent really ever seen it be discussed. There is some very sketchy stuff going on in the depths of the darksend code, I suggest all you investors dive deeper and take a look

I'm assuming we're referring to addresses:

Xq19GqFvajRrEdDHYRKGYjTsQfpV5jyipF
y1EZuxhhNMAUofTBEeLqGE1bJrpC2TWRNp

With the first not having activity since July 31, 2014 and the latter with no activity. I could be wrong, but these could be part of the legacy DS before all collateral and fees went to the network.

If you're referring to something else, I'd love to know where.


It used to be used for DS collateral transactions, but I thought it was a better idea to pay collateral to the miners in the form of a transaction fee. I didn't remove the actual key though, because it's used to check masternode inputs to make sure they're valid.

Here's the only two places it's referenced in the code currently:
https://github.com/dashpay/dash/blob/master/src/masternode.cpp#L265
https://github.com/dashpay/dash/blob/master/src/masternodeman.cpp#L674

Once those two references are fixed, it can be completely removed.

I think this is a good solution. +1