Important to correct the dynamic staking code taken from coin Positron.
I wonder if the new wallet has a higher version number and if it checks that nodes have the new wallet.
it doesn't check obviously.
and a lil easier advice to everybody: always delete peers.dat after you close the wallet.
that way next launch you'll feed it from seednode and not some shitnodes
Actually it does check.
https://github.com/teamneutron/Neutron/blob/master/src/version.h#L39The problem is that this dynamic staking code that came out of Tron is broken/not implemented correctly. I am surprised Tron has not started having issues yet.
Check it out:
https://github.com/teamneutron/Neutron/blob/master/src/main.cpp#L1036Do you see the problem in that code? It is checking the block height against pindexBest, which is a pointer to the tip of the chain. But that varies as you sync. If you get a bunch of other block inventory for your node to check, its always going to be trying to assign a reward based on what it thinks the tip of the chain is, not the relative height of a particular block.
i'm not into C at all, simply logically if it connects to any nodes any version
and even ignores connect=ip option, that means there is NO check actually,
i see constants in code, but behavior doesn't follow.
and btw, how many version already have the same protocol 60014
Actually thats completely and totally wrong. The existing wallet respects connect= correctly. The previous version was protocol version 60013 with a min required version of 209 as seen here:
https://bitbucket.org/neutroncrypto/neutron/src/880cb18109884e1168e76a3d96fde8987a38c38e/src/version.h?at=master#cl-39.
The new seed/checkpointing/other nodes will disconnect anyone who is not on protocol 60014.
Can simply replace the dynamic award at a constant? This will solve the problem?
Don't need to do that, its one of the features of this coin that makes it attractive. Just need to modify the reward methods to accept a height parameter and pass the (previous block index + 1) to it from checkblock etc.