Ninjastic
PostEdited versionsQuotes to this post
Post
Topic
Board Pools
Re: [1500 TH] p2pool: Decentralized, DoS-resistant, Hop-Proof pool
by
K1773R
on 24/07/2015, 16:49:27 UTC
Quote from: CartmanSPC on July 23, 2015, 11:06:16 PM
Quote from: K1773R on July 23, 2015, 04:25:57 PM
Quote from: CartmanSPC on July 23, 2015, 06:55:30 AM
Was reviewing the code and came across this one part:

https://github.com/forrestv/p2pool/blob/master/p2pool/data.py#L152

Question: Why limit it to "50 kB of new txns/share"?


i even contacted you about that bug months ago Wink was asking forrestv about it, but he didnt respond. created a hackish fix in my repo.

Hehehe, I wasn't in a right "state of mind" back then...still questionable now. Wink

I see that you increased it to 500 kB in your fork and imagine it was the solution to mining those "stuck" ANC transactions.

Like zvs said...probably done to avoid an orphan due to block size.
the problem is, per default p2pool cant include a tx that is bigger than 50kB, which is a shame! usually the big txs pay very well (if they arent dust). when i was mining BTC on p2pool i was prefering big txs which paid more than smaller ones. i never included one of the big ones, but i didnt wonder back then. until i hit it again when mining ANC.