Are there any unit tests associated with this trading agent?
Based on the number of defects identified so far, the software engineer in me is kicking in and going "you really shouldn't be playing with this until it has better test coverage"
Sorry guys I was AFK. If something like this is uncovered in the future and I haven't responded in 10 minutes or less, text me 801-477-7150 and I'll respond as soon as possible.
As far as unit test, the code base is too influx for unit test to be of much use. So much changes from commit to commit that by the time I would write a unit test it would be effectively invalid and trying to fix it would delay releasing a critical fix such as this even further.
Yes this is a >< transposition, according to the commit logs I screwed this up in the last commit.
Fortunately it's in the buy section and it's making it so the buy threshold is never reached. According to the algorithm you've missed some bargains, but it looks like it hasn't cost anything yet. The bad part is that if that threshold were to somehow become positive (a market crash) you would end up lots of buying lots of bitcoins at WAY above market rates.
I'm going to swap the comparators and commit. I apologize for the bug.