I understand that this is being framed as "protection from DOS attacks from TOR nodes." Can anyone explain to me why this is necessary? Has DOS attack by the TOR network ever been a real threat -- and if so, could one provide proof? TOR nodes are easily tracked, easily blacklisted. Aren't serious DOS attacks run off botnets? How does this code actually prevent DOS attacks? It merely "deprioritizes" (to zero access?) IP addresses by mere association.
Is DOS a real threat to the bitcoin network? If so, how does effectively IP banning TOR nodes do anything to address that? This is like setting a mouse trap for a plague of locusts. I'm at a loss for how this provides security to the network. At best it seems extraneous, at worst..... let's just say, I don't know that this list will be limited to TOR nodes. And I am concerned that targeting nodes and denying access to the network based on IP address could be a slippery slope when new commits come along down the road.
On what basis are IP addresses deprioritized? Who decides what addresses/batches of addresses are deprioritized? Can this deprioritization be used to prevent nodes from accessing the network entirely? This is supposedly about the TOR network -- though I'd like to see some evidence that the TOR network poses any threat whatsoever to the bitcoin network. Could this potentially be used to target other groups of nodes on some other basis, regional or otherwise?
What TOR DOS is doing to XT nodes is that is asking for a big old blocks that are not in memory so you need to look on a disk. So weary littel traffic is necessary to stop node operating...
I would agree that TOR deprioritizing(it is really not banning read the code) will not help much if the attacked would start coming for normal network. For now they are coming from TOR. Mike is making a patch that will deprioritize nodes based on what they are doing but this was a quick fix since XT network was under attack.
If the whole network would be DOS attacked then TOR nodes would have harder time connecting. TOR is deprioritized since attacks are coming from there and since exchanges and payment processors are not using it.
And this is much batter then what I was using. I was using DROP on FW. And I didn't remove it since attacks were repeating itself. Now I serve TOR in time I'm not attacked... So that fix things for to not make them worst...