Why does Hearn want to cram huge controversial poison-pill commits into XT along with the popular blocksize commit of Gavin's is the real question.
It's like those politicians cramming all the surveillance shit in the "Schumer Bill For The Protection of Widows Orphans and Kiddies."
Its a rule that you can turn off anytime. Reason its a controversy because someone make it be.
The XT was under DDoS attack, he had to write a defense mechanism quick. This feature does not affect anyone's privacy. You cant let emotion and prejudice to blind you
It logs your IP and potentially puts it on a blacklist, even if you're on tor or a proxy. That is the definition of compromising privacy.
The offensive comment and code you mentioned :
//A group of logically related IP addresses. Useful for banning or deprioritising sources of abusive traffic/DoS attacks.
... refers to Tor proxy peers. Not the originating (connecting) peer. Which it wouldn't know anyway because...tor.
Yes just a coment. But it is "Useful for banning or deprioritising" not "Will be used for banning and deprioritising"
The code then uses it for "deprioritising" but not for "banning" when attacked from TOR
You can't use only one line
EDIT: And no idea what you talking about hire
Not the originating (connecting) peer. Which it wouldn't know anyway because...tor.