I think we will see impact of bitcoin halving on price before it actually happens, around 2-3 months earlier then halving but at the time of halving there will nothing shocking rather then normal price movement
We probably will, no matter when price will go up, it would be great for bitcoin and miners especially 