Theoretically, if secp256k1 were broken then there would be a strong incentive to migrate to another algorithm.  The migration may specify a deadline past which all old-format outputs are deemed unspendable.  In this event, yes, coins stored with an old version of Bitcoin Core and not rescued in time could end up locked away forever.