Any suggestions for improvement?
Feel free to use the issues page on github to report any bugs or issues: https://github.com/aido/IsisATP/issues. I suppose it's a better way to track these sort of things. I see there are currently 0 issues, so the code must be perfect
...
You also mention a deadlock. Are you sure it's a deadlock causing the problem? I recently changed the Ticker Manager code to use streaming instead of polling. I think the socketIO connections could be dropping. I currently don't have any check to test and reconnect a dropped socket. I hope to add this functionality as soon as it is added to XChange:
https://github.com/timmolter/XChange/issues/6
Maybe if someone 'nudged' the developer of XChange it may encourage a speedy implementation of this functionality in his code.
When I get a chance I'll test for deadlocks also, just in case. I had already written a handy script to make it a lot easier to test for deadlocks in the original Isis code.
Well to be honest it's going to take me a little while to get my head around the project currently. I can't just step in and know what you guys have spent months working on. Feel free to use the issues page on github to report any bugs or issues: https://github.com/aido/IsisATP/issues. I suppose it's a better way to track these sort of things. I see there are currently 0 issues, so the code must be perfect
...
You also mention a deadlock. Are you sure it's a deadlock causing the problem? I recently changed the Ticker Manager code to use streaming instead of polling. I think the socketIO connections could be dropping. I currently don't have any check to test and reconnect a dropped socket. I hope to add this functionality as soon as it is added to XChange:
https://github.com/timmolter/XChange/issues/6
Maybe if someone 'nudged' the developer of XChange it may encourage a speedy implementation of this functionality in his code.
When I get a chance I'll test for deadlocks also, just in case. I had already written a handy script to make it a lot easier to test for deadlocks in the original Isis code.
I did notice some things that can be cleaned up nicely and quickly though which should make every ones lives easier.I suppose you're right as I have no way of knowing until I step through the debugger to see where it's hanging whether or not it's deadlocking or just dropping connection. I forgot this program doesn't take user input while the feed is going so 'deadlocking' may not be the best term. .... so you're saying all the market connection and data streaming is coming from a different project? Oh bugger, this could make life interesting if we have to start making our own fixes AND keep track with these other projects.