Re: Moving forward with Armory

Quote from: goatpig on February 04, 2016, 05:58:47 PM

Quote from: coins101 on February 04, 2016, 09:07:47 AM

Happy to take a look at the IP issue and give you some informal feedback / personal view.

Thanks for the help =). This is my current situation:

I'm mostly concerned about how to properly deal with license headers and wording on the repo, to make it clear the new code is MIT and mine and the old code is GPL3 and ATI's.

This is the original license: https://github.com/etotheipi/BitcoinArmory/blob/master/LICENSE

This is the modified one on my fork: https://github.com/goatpig/BitcoinArmory/blob/dev/LICENSE

Is this acceptable?

Also, this is what the license header looks like on the original code: https://github.com/etotheipi/BitcoinArmory/blob/master/cppForSwig/BlockUtils.cpp#L1

I have modified some of that code already by did not modify the license text on any of the original code files.

This is the header on all new code files: https://github.com/goatpig/BitcoinArmory/blob/dev/cppForSwig/BlockDataMap.cpp#L1

Those files are 90~95% new code, I've copied some of the original utility code into the new class.

Did I mess up anything?
....

First, I'm not a lawyer. But, unfortunately, I have spent many years in dark rooms with lawyers talking about IP on software.

I think what you have done looks ok. I've read through the Armory GNU licence and basically you need to add this to the source code that was created by Armory:

Code:

Copyright (C)

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Affero General Public License as
published by the Free Software Foundation, either version 3 of the
License, or (at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Affero General Public License for more details.

You should have received a copy of the GNU Affero General Public License
along with this program. If not, see .

http://www.gnu.org/licenses/agpl-3.0.en.html

So, you'll have a mixture of code licences that you might want people to compile according to where the code starts:

* Armory code should start with the Armory licence terms

Code:

Copyright (C) 2011-2015, Armory Technologies, Inc. //
// Distributed under the GNU Affero General Public License (AGPL v3) //
// See LICENSE or http://www.gnu.org/licenses/agpl.html

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Affero General Public License as
published by the Free Software Foundation, either version 3 of the
License, or (at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Affero General Public License for more details.

You should have received a copy of the GNU Affero General Public License
along with this program. If not, see .

* Your new code can then start with:

Code:

// Copyright (C) 2016, //
// Distributed under the MIT License //
// See LICENCE or https://opensource.org/licenses/MIT //

I take it there is no other code you'll be using that has come form Armory, that has not been released on the GNU licence?

By using the Armory code now, you should be ok if someone decides to buy the company or its assets and then changes the licence.

I'll keep reading around to see if the above thoughts need modification.