Re: [1500 TH] p2pool: Decentralized, DoS-resistant, Hop-Proof pool

Quote from: veqtrus on March 26, 2017, 06:59:06 AM

Quote from: forrestv on March 25, 2017, 11:31:53 PM

As a separate issue, I now realize that current P2Pool doesn't allow *expressing* support for SegWit, due to line 372 in work.py, which veqtrus's changes don't touch:

Code:

version=max(self.current_work.value['version'], 0x20000000),

If anyone can confirm that fixing that is as simple as changing it to

Code:

version=max(self.current_work.value['version'], 0x20000002),

This is wrong. I changed p2pool to signal whatever BIP9 compatible fork a client supports in the CSV commit.

Ah, oops. I misread max as what it used to be (min). Great, so that's not a problem.

Quote from: sawa on March 26, 2017, 10:27:40 AM

How to get out of this situation? Now for my node I use veqtrus patches from the segwit1+empty_block_fix1 branch of a https://github.com/veqtrus/p2pool.git repository.
When my node's hashrate was raised and the amount of v17 shares was increased above then 50%, the message with a link to p2pool.in appeared on another nodes. But there is no announcement about a new version. Owners of other nodes will not do anything.
What to do if the main developers can not agree?

sawa, you shouldn't be using the fork right now. The main branch does everything you could want right now (namely, just indicate SegWit support). A majority of P2Pool hashrate using a fork will indeed confuse other miners.