Different workers have the same value "bestshare" and "bestever".
This is normal?
Have all previous decisions been canceled?
No? That's not the behaviour I see nor how I designed it. The behaviour is much the same. The only thing different is that all users are loaded at restart now so some users may have stale results from previous blocks if they've been idle for a long time across restarts, but that will never happen again as I'm trying to maintain the state permanently now. I was surprised myself to find 15000 different users loaded up with the new code. Best share is best share this block, best ever is best ever share found. It's per worker, and overall for the user.
EDIT: After PM discussions it's apparent there is an issue with the workers all showing the same best shares. It seems to only have happened on the reload with new worker best shares working correctly and I'll investigate before the pool is restarted again - though I don't foresee another restart any time soon. Luckily it's only cosmetic and won't affect our block finding, so we just need to find a block to reset all the best shares.