I'd like to know what the kind of your coin because every coin has a different method to keep them in the cold storage. But Use the hardware wallet if you are trying to hold bitcoin for some years later.
I have an online wallet for my Bitcoin in case I wanted to withdraw it and convert it into fiat. I'm also int trading altcoins and just storing them on trading sites and waiting till the value increase before I sell them.