Unsure if this is the right place to bring out code problems, but I am getting this failure when compiling from devcoin master:
$ cd src; make -f makefile.unix
/bin/sh ../share/genbuild.sh obj/build.h
g++ -c -O2 -pthread -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -D_FILE_OFFSET_BITS=64 -I/home/aatheus/git/devcoin/src -I/home/aatheus/git/devcoin/src/obj -DUSE_IPV6=1 -I/home/aatheus/git/devcoin/src/leveldb/include -I/home/aatheus/git/devcoin/src/leveldb/helpers -I/home/aatheus/git/devcoin/src/curl/include -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -D_FORTIFY_SOURCE=2 -MMD -MF obj/rpcrawtransaction.d -o obj/rpcrawtransaction.o rpcrawtransaction.cpp
In file included from bitcoinrpc.h:17:0,
from rpcrawtransaction.cpp:9:
json/json_spirit_writer_template.h: In function String_type json_spirit::non_printable_to_string(unsigned int):
json/json_spirit_writer_template.h:31:50: warning: typedef Char_type locally defined but not used [-Wunused-local-typedefs]
typedef typename String_type::value_type Char_type;
^
In file included from /usr/include/boost/iterator/iterator_categories.hpp:22:0,
from /usr/include/boost/iterator/iterator_facade.hpp:14,
from /usr/include/boost/range/iterator_range_core.hpp:27,
from /usr/include/boost/range/iterator_range.hpp:13,
from /usr/include/boost/assign/list_of.hpp:20,
from rpcrawtransaction.cpp:6:
/usr/include/boost/variant/get.hpp: In instantiation of typename boost::add_reference::type boost::strict_get(boost::variant&) [with U = const CScriptID&; T0 = CNoDestination; T1 = CKeyID; T2 = CScriptID; T3 = boost::detail::variant::void_; T4 = boost::detail::variant::void_; T5 = boost::detail::variant::void_; T6 = boost::detail::variant::void_; T7 = boost::detail::variant::void_; T8 = boost::detail::variant::void_; T9 = boost::detail::variant::void_; T10 = boost::detail::variant::void_; T11 = boost::detail::variant::void_; T12 = boost::detail::variant::void_; T13 = boost::detail::variant::void_; T14 = boost::detail::variant::void_; T15 = boost::detail::variant::void_; T16 = boost::detail::variant::void_; T17 = boost::detail::variant::void_; T18 = boost::detail::variant::void_; T19 = boost::detail::variant::void_; typename boost::add_reference::type = const CScriptID&]:
/usr/include/boost/variant/get.hpp:284:25: required from typename boost::add_reference::type boost::get(boost::variant&) [with U = const CScriptID&; T0 = CNoDestination; T1 = CKeyID; T2 = CScriptID; T3 = boost::detail::variant::void_; T4 = boost::detail::variant::void_; T5 = boost::detail::variant::void_; T6 = boost::detail::variant::void_; T7 = boost::detail::variant::void_; T8 = boost::detail::variant::void_; T9 = boost::detail::variant::void_; T10 = boost::detail::variant::void_; T11 = boost::detail::variant::void_; T12 = boost::detail::variant::void_; T13 = boost::detail::variant::void_; T14 = boost::detail::variant::void_; T15 = boost::detail::variant::void_; T16 = boost::detail::variant::void_; T17 = boost::detail::variant::void_; T18 = boost::detail::variant::void_; T19 = boost::detail::variant::void_; typename boost::add_reference::type = const CScriptID&]
rpcrawtransaction.cpp:241:77: required from here
/usr/include/boost/variant/get.hpp:178:5: error: invalid application of sizeof to incomplete type boost::STATIC_ASSERTION_FAILURE
BOOST_STATIC_ASSERT_MSG(
^
makefile.unix:182: recipe for target 'obj/rpcrawtransaction.o' failed
make: *** [obj/rpcrawtransaction.o] Error 1
Apparently this is a know issue with Ubuntu 16.04. Per
https://github.com/bitcoin/bitcoin/issues/6113#issuecomment-298234393 - I made the change, and the code is compiling fine now.
Anyone who is a dev who can get this into the code base? It seems like a trivial change.