Re: [BBR] Boolberry: Privacy and Security - Guaranteed[Bittrex/Poloniex]GPU Released

Quote from: sowle on June 01, 2017, 05:24:31 PM

Quote from: joggel on May 30, 2017, 10:24:38 AM

I can not sync BBR Blockchain.
At Block 757131 get a "Block recognized as orphaned and rejected" message.
And this for hours.
i use a seed node 5.9.44.154:10101

Got the same issue.

I found out there are txs with invalid key_image in the blockchain. The first one is at block 757131.
On May 9th zoidberg commited a security fix from monero (https://getmonero.org/2017/05/17/disclosure-of-a-major-bug-in-cryptonote-based-currencies.html) and now each input is being checked against invalid key_image. That's good.
Unfortunately, by the time he commited the fix there had already been malformed txs in the blockchain. That's why blockchain can't be resyncronized from the beginning now.

I send a pull request to address this issue: https://github.com/cryptozoidberg/boolberry/pull/54

Thank you, buddy, jut one little question: why you acquire m_blockchain_lock (it's already owned by this code at the beginning of function)?

Code:

CRITICAL_REGION_BEGIN(m_blockchain_lock);
top_block_height = m_blocks.size() - 1;
CRITICAL_REGION_END();