Yep, exactly.
There's only 2^140 possible addresses! Get cracking!
2^140 = 1393796574908163946345982392040522594123776
After making some code changes on a single thread on a CPU I was able to generate these stats after 12 hours:
wallet 9793ms
Rescanning last 131051 blocks (from block 0)...
rescan 24540ms
Done loading
mapBlockIndex.size() = 131055
nBestHeight = 131051
mapKeys.size() = 399643
mapPubKeys.size() = 399643
mapWallet.size() = 0
mapAddressBook.size() = 399538
So about 33294.833333333 public/private key pairs per hour on a shitty processor. I also did mispeak I now realize that I'm not generating "wallets" but rather just a hash that contains public/private key pairs. This is probably not the most efficient way to perform such an attack, having a pool of computers generating the public/private keypairs would be a much better method. However, I have determined that the current system is safe enough for me
I hope that someone with more time to dedicate to this is not successful. I will still trust in a bank external to the bitcoin system with the vast majority of my money because there is a remote chance out of "luck" someone may generate my public/private key pair, reconstruct the transactions in their wallet and drain all of my cash. I will be testing again with some GPUs once my hardware comes in, sorry about the RPC flood, lol. I guess at least the network is resilient enough to not even notice.