Post
Topic
Board Announcements (Altcoins)
Re: BiblePay - New Coin Launch - Official Thread
by
bible_pay
on 14/10/2017, 17:23:51 UTC
Does the pool mining have advantage over solo mining?
Just have some time reading the miner code.

I saw in BibleMiner
   in nonce loop            if ((pblock->nNonce & 0x7FFF) == 0)
                                  break;
       out of the loop                            if (pblock->nNonce >= 0xFF)                    
                                                               break;
 So anything after the above statement will be ignored (pblock->nNonce will be 0x8000 which is always > 0xFF):
                // Update nTime every few seconds
             if (pindexPrev)
            {
               if (UpdateTime(pblock, chainparams.GetConsensus(), pindexPrev) < 0)
                  break; // Recreate the block if the clock has run backwards,
                        // so that we can use the correct time.
            }
 The miner cannot just update the ntime to create a new task without createnewblock?    



Actually, you did find something valuable here and this is true: we would gain a very small HPS increase by readjusting that 0xFF condition that is out of the loop- to the proper trigger level- and now - I will fix this asap.

But I do want to mention this so no one freaks out:  This inner loop is only exited about once every 15 seconds, so the difference between updating the timestamp and creating a new block template will not be very much (probably 10 HPS difference), but, thank you very much for pointing that out. 

I think what happened is I raised the inner loop high to try to squeeze out more HPS, and never readjusted the 0xFF.