Post
Topic
Board Project Development
Re: [ANN] MarginBot - A Bitfinex Margin Lending Management Bot
by
mt717
on 31/10/2017, 01:38:54 UTC
I think the new coin BTG may have broken something. Starting on 10/24 my error logs on v1.08 filled up due to an infinite loop.

[Tue Oct 31 01:04:42.359979 2017] [:error] [pid 3349] [client 52.6.250.144:60840] PHP Warning:  Division by zero in /var/www/html/bitbot/inc/ExchangeAPIs/bitfinex.php on line 374
[Tue Oct 31 01:04:42.360010 2017] [:error] [pid 3349] [client 52.6.250.144:60840] PHP Warning:  Division by zero in /var/www/html/bitbot/inc/ExchangeAPIs/bitfinex.php on line 380

It seems to all start with this issue:
[Tue Oct 31 01:04:42.359667 2017] [:error] [pid 3349] [client 52.6.250.144:60840] PHP Warning:  file_get_contents(https://api.bitfinex.com/v1/lendbook/btg/?limit_asks=500&limit_bids=0): failed to open stream: HTTP request failed! HTTP/1.1 400 Bad Request\r\n in /var/www/html/bitbot/inc/ExchangeAPIs/bitfinex.php on line 229


Notice the "BTG" in the URL.
https://api.bitfinex.com/v1/lendbook/btg/?limit_asks=500&limit_bids=0

This returns {"message":"Unknown currency"}

Change "btg" to any other coin code and it works fine. It seems the code is pulling back all coins and trying to get the lending book, so when BTG started coming back as a valid coin, it tries to get the ending info and fails.

Any suggestions on a quick fix or maybe a code update?