Also it looks like the subsidy for blocks 249 & 250 are undefined.
<249 = 0
>250 = 49
249 ?
250 ?
Likely should have been
<250
>=250
Not sure what is going to happen at block 249.
Look above, nSubsidy is initialized to 0.
(Amusingly if it wasn't, then each time the blockchain was scanned it would assign random extremely high values to those blocks (likely in the quadrillions), and I think the coins would be spendable in a transaction, but some nodes that calculated the reward as lower randomly would reject the blocks, leading to constantly forks forever after.)
Yeah I noticed that (see "on edit") after posting. However it looks like no block will get the lottery due to the order of the if statements.