See my comment on the pull request
(also note that Accepted/Rejected etc should rarely if ever be used, they should use "Difficulty Accepted"/"Difficulty Rejected" etc ...)
Appreciate the feedback!
Humbled to be receiving direct input from somebody so directly involved while I'm definitely new. Sure is a flat org chart around here!
The comments between here and the git commit make more sense. I'm also studying the cgminer README -
https://github.com/ckolivas/cgminer/blob/master/READMETo summarize, it is best practice to not really use the accepted, rejected and discarded columns and better to focus on the Diff1Shares, Difficulty Accepted and Difficulty Rejected columns?
To convert this over to the code currently used on the minepeon pool stats section, attention should be focused on: " . $pool['Diff1Shares'] . ", " . $pool['DifficultyAccepted'] . ", and " . $pool['DifficultyRejected'] . " ?
This might come across as a silly question .. I was wondering why there isn't a discarded number for diff1shares? Perhaps hardware errors under the specific mining device are related to the discarded number?
I'm positive I'm missing something here, but just attempting to make the stats/calculations as accurate as possible