Many many people say they are holding this, holding that for the "long term" but please tell me what exactly is your guys definition of "long term"?
For me, 1 year is considered long time. I began investing this January and I will hold one year and cash out everything January 2019. So by your definition, is this more short term or long term? Is 1 year enough time to see gains?

I would consider it long term. Some of my trades literally only take 10 minutes if I get lucky. Yes, 1 year is plenty enough time to see gains. However, the cryptocurrency market has gone down by quite a bit every January for the last few years. So you may want to keep an eye out come December at the price of your coins and sell then.