Many many people say they are holding this, holding that for the "long term" but please tell me what exactly is your guys definition of "long term"?
For me, 1 year is considered long time. I began investing this January and I will hold one year and cash out everything January 2019. So by your definition, is this more short term or long term? Is 1 year enough time to see gains?

I'd say medium.
Long term is holding indefinitely, until a opportunity comes to sell. For example, when the next pump cycle for bitcoin comes. Long term holding doesn't have to have a minimum amount of years, it's just that you're prepared for anything to happen before that selling opportunity.
1 year isn't short term, and isn't long term. Therefore, medium term investing should be the right term to use.