I always feel that offline is the best.Offline wallets is only for stopping and holding large amount of Bitcoins. If you gamble or trade frequently then online wallet is a better choice for you.
Offline wallets are best in case you do not want to transact often. Online wallets are good in a sense that you can easily access them and can to transactions instantly, but i advise you not to keep majority of the coins in online wallets and keep your savings in offline wallet.