Looks ok, better than alternative profit-switching pools but the profitability calculation method sounds very basic.
You should take into consideration things like:
- Trading volume in the exchanges you use. (i.e will you be able to dump large amounts of the currency without making the price plummet?)
- How stable the cryptocurrency's price is
- How frequently does the cryptocurrency's difficulty update? (Will we be able to mine here for a worthwhile time without the difficulty skyrocketing because of your hashpower)
Basically, I'm not going to mine with a profit-switching pool until they take into account things like this, or I'd be making much more profit mining on my own, manually.
Without getting into all the specifics, the profitability algorithms take into account any current balances the pool has already earned, and starts calculating profitability after that point (ie: if the pool sold off all its balances of coin X at market price, what is the new price). We also average out that new price number over a certain depth of coins, to ensure we aren't just taking the highest market order. That is just for profitability, we then do a similar task when attempting to trade mined coins, also factoring in what the price was (from above) when we first started mining).
Stability of price is somewhat covered above. Obviously everything fluctuates.
Frequency of diff adjustments certainly has to be taken into account. There are a few fast adjusting coins that we may mine for a slightly longer window than we should, though the profitability checks do happen fairly frequently, and often even after diff adjustments the same coin ends up ahead. These kind of adjustments will be fine tuned as the pool grows, and we see the affects of its round times on the outcomes.
Thanks for the feedback!