Both Trezor and Ledger Nano S are good choice. It will be no bad choice between them. I'd even say - must have at least one of them, if you are holding some real amount of coins.
Ledger Nano S had the first burglary:
The story began in November 2017 when Rashid reported a bug to Nicols Bacc, director of Ledger Nano, who might allow attackers to steal users' wallet funds.
Rashid noticed that the microcontroller used in the wallet was not safe. Although it allowed the use of buttons and screen for entering data, it was connected as a proxy with the Secure Element (SE). The latter contained private keys, which meant that the hacker could cheat the SE in different ways. Here's how: retailers and resellers can change the microcontroller's system software, which, now at risk, can verify its "identity" in the SE. Rashid further explained that the attacker could control the user interface and use malicious code to set the randomness to zero and add his own seed for recovery. Rashid chose the word "abandon" to prove his opinion in the uploaded video material. Now that the attacker has a mnemonic phrase, they could easily obtain private keys.
After Rashid sent the study to Ledger, he saw that the band did not take him seriously. Nevertheless, they published a firmware update on March 6, which was severely criticized by Rashid. He published his opinions on this topic on Twitter because he thought that theLedger team should publish his information and turn on the problem solution for the next critical update or hide it so that the hackers would not have time to use this trick.
Well, it looks like it's advertised as the safest hardware porfet to store cryptocurrencies is not that safe anymore, since the holes and errors in the microcontrorel software have been found for 15 years ...