..
Here's a detailled code report.
I took ALL the commits made by Twobits or twobits in the devcoin client.
I made a list from all the changes made by twobits and compare with the code of Sidhujag.
Thank you for your excellent code report, you get 12 shares:
https://raw.github.com/Unthinkingbit/charity/master/bounty_31.csvThe last remaining code report bounty is 6 shares.
..
The first difference about the timestamp on bip30 I think that is to avert a potential problem in the future so since blocks are already created and patch is applied I think its safe? Unless someone can prove me wrong?
I agree, it should be the same as Twobits's version. It will work anyways, but it's one less difference to keep track of.
..
pblock->vtx[0].vout[0].nValue = GetBlockValue(pindexPrev->nHeight+1, nFees);
txNew.vout[0].nValue = minerValue + nFees;
in devtome wiki technical
But in all codes (twobits,Sidjuhag) , it's pblock->vtx[0].vout[0].nValue = minerValue + nFees;
pblock->vtx[0] is txNew
because the txNew is the first transaction to be placed on the block:
// Add our coinbase tx as first transaction
pblock->vtx.push_back(txNew);
so it should be changed in the code to txNew instead of pblock->vtx[0] because it's simpler and easier to read.
..
MIN_TX_FEE = MIN_RELAY_TX_FEE = 500,000,000 but in Twobits and Sidhujag values are
100,000,000 = COIN
Why ?
Twobits changed that without telling me. I didn't know because at the time we couldn't afford a code review. Now that blocks have been made with Twobit's lower transaction fee, the change must be kept and I will change the wiki documentation.
For the port difference noted by cyke64:
port used by RPCPORT is always 52332 (there's no testnet) in twobits instead of bitcoin RPCPORT 8332.
In Sidhujag , port used is 7332 defaut and for testnet 17332 (src\bitcoinrpc.cpp,src\init.cpp)
Could it be the source of your problem ?
Sidhujag wrote:
The default rpcport is a setting in the conf file that I oerwrote I can connext so its working. I will change this but its only useful for proxies and if conf file doesnt specify rpcporr in the firet place...
Otherwise we just need to send a few coins back forth to confirm fees and mining merged works.
I'm glad this will be changed. Even if it's overwritten, it's still good to have it the same as the documentation to prevent confusion.