And to say this code is inferior when the old Stipend coin is set to produce infinite blocks but claim a max supply of 19 million is laughable.
else if (pindexBest->nHeight+1 > 840001 && pindexBest->nHeight+1 <= 1890000) {
// end game - further discussion needed
nSubsidy = 3 * COIN;
} else if (pindexBest->nHeight+1 > 1890000) {
// end game - further discussion needed
nSubsidy = 3 * COIN;
nSubsidy >>= ((pindexBest->nHeight + 210000) / 1050000);
}
There is a mandatory hard fork required in the Stipend code, or it will produce an infinite number of blocks. THIS is unfixed code.
There is a mandatory hard fork also required in the Stipend Zenith code, but much, much sooner (although after your masternodes are sold which is probably all the concerns you). THIS is unfixed code.
When I reveal the issue I'm aware of in your code, you'll see how the Stipend Zenith code issue is much, much more basic - and will cause problems a hell of a lot sooner. I wouldn't expect the issue I'm aware of in a school project, never mind an officially released cryptocurrency.
Personally, I haven't reviewed the Stipend code so cannot comment on the above.