If you want to hold a certain amount of coin the wallet is a better option. However, if you are an active trader and makes money by day trading then keeping your assets in an exchange is a better option, the reason being wallet to exchange transfer incur trading charges. Keeping all your money in an exchange is quite risky as an exchange can shut down and flee.