There are both advantages and disadvantages with trading and mining.

Mining advantages
No extra fee charged for mining apart from investment.
Risk free in long run
Consistent profits

Mining disadvantages
Long term investment
Can't earn money quickly
Huge time involvement

Trading advantages
Quick profits
No investment in equipment
Easy to manage like sell high buy low

Trading disadvantages
Requires more skills than trading
Impossible to predict prices
Trading fee
Higher risk