Greetings clo1,
Thanks for posting your code. I've skimmed it and would like to assist if possible (I can perhaps help with gitian, builds, and tests). In the interest of more easily auditing/maintenance would it be possible to add your commits on top of the latest 0.16 code from upstream, preserving the git history? Also, it might be easier to not unnecessarily rename files to ease future merges.
For instance, I've created a new github organization:
https://github.com/riecointeam/riecoinIf you put your changes on the master branch it might make things more clear. (Or gatra can update riecoin/riecoin.git master to 0.16, whatever.)
FWIW, I don't have an interest in taking a share of your rightly deserved bounty.
Nice work!
Help in these areas would be great.
Just to be clear, is the code you listed the latest bitcoin 0.16 code? I can add my code to this, but I want to check a couple more things before I start.
Most of the filenames I changed were also changed in the original code ... images, riecoind, riecoin-cli, a few others. I might have changed a couple extra in the qt code (bitcoingui.cpp -> riecoingui.cpp).
Similarly, a lot of the changes are text substitutions of bitcoin for riecoin. This was true in the original code and given how much the code has grown since then is worse now. It would be easy for me to do a separate commit of all the text substitutions so that the main riecoin changes are more obvious.
My approach was to change all filenames and all text (except copyrights and a couple others). Let me know if this is a problem. Changing some, but not others will make things more difficult.
I'm not sure if I will get the bounty but if I do I plan to share a portion with others contributing to Riecoin.