I am looking for the best wallet to safely store my bitcoin for the next lot of years (who knows how long) is bitcoin core a safe place to do this or should i look at others?
it's not about the wallet you are using but it's all about your pc and how you take care if your kets and password. Buying ledger is not really recommended to you to buy but just buying a legite anti virus and making your pc clean then that will be safe and you can now use it for a long time.