Post
Topic
Board Armory
Re: Can Armory multisig lockbox have more than one funding address?
by
idoB
on 27/09/2018, 06:48:02 UTC
Thanks for the explanation.

In retrospect (always 20-20), I was sniffing close to  the section of the code that turned out to be the issue, in the file /ui/MultiSigDialog.py, which is why I asked you for a confirmation of the file in a previous post.

What made me look closer, however, wasn't any coding expertise unfortunately, (I was having a hard time just getting my head around what I was reading), but these two lines that hinted on fragile code  Wink :

Code:
      # Not sure if we really need this...
https://github.com/goatpig/BitcoinArmory/blame/testing/ui/MultiSigDialogs.py#L2983

and
Code:
      # This is complex, for sure.
      #    The outermost loop goes over all inputs and outputs
      #    Then goes over all N public keys
 
https://github.com/goatpig/BitcoinArmory/blame/testing/ui/MultiSigDialogs.py#L2991

But eventually I got derailed by what you commented as unrelated.

I would'nt have guessed that compressing keys changes their order (which is critical for signing a lockbox spending transaction).