Ninjastic
PostEdited versionsQuotes to this post
Post
Topic
Board Development & Technical Discussion
Merits 1 from 1 user
Re: The duplicate input vulnerability shouldn't be forgotten
by
Lauda
on 28/09/2018, 06:53:23 UTC
⭐ Merited by ETFbitcoin (1)
Quote from: hobbes on September 28, 2018, 06:49:02 AM
Quote from: Lauda on September 28, 2018, 06:41:58 AM
Quote from: aliashraf on September 28, 2018, 06:37:08 AM
(...)
I maintain my arguments up-thread regarding software bloat as the most distinguished source of bugs. I understand it is the hard way and needs a lot of efforts but once you are concerned about bugs, best practice is to take care of code volume.
A complete separation of node and wallet code (i.e. the possibility of just building and running the node base) would help IMO. It does come with drawbacks though.
At least for alternative implementations for monitoring it is the way to go.

Could you elaborate on the drawbacks?
ryanofsky is working on process separation as seen here: https://github.com/bitcoin/bitcoin/pull/10973. Here are his slides regarding process separation: https://docs.google.com/presentation/d/1AeJ-7gD-dItUgs5yH-HoEzLvXaEWe_2ZiGUUxYIXcws/edit#slide=id.p. Look at page 6.
Reviewing the node code would be easier if it was completely separated from the GUI and wallet code (there would be noticeably a lot less lines of code to go through). I'm not sure if the end goal is complete separation though.