Re: [ATTN: POOL OPERATORS] PoolServerJ - scalable java mining pool backend
Yes, I've seen those libraries. It's very nice of you to open source PoolServerJ! It seems to be a nice piece of software. No need to send me a permission, I simply asked because I was wondering what "no derivative works" means (and why the source code is public then). Now it's all clear, the license has not been updated and it used to be closed source. 
I've tested PoolServerJ and so far I'm impressed. The possibility to write your own sharelogger and simply plug it into PoolServerJ with a config file directive is nice. I implemented one that logs invalid shares to their own table (BTW: if "entry.reason == null && entry.ourResult" evaluates to true, is it safe to assume that this share is valid and should be counted for rewards?).
However I'd like to report a bug, or at least I think it is a bug.
I changed phoenix to do this:
I actually find 20 shares in my table when only one should be valid, and they all have "our_result == 1".
Maybe the problem is with Res.getEasyDifficultyTargetAsInteger()?
I've tested PoolServerJ and so far I'm impressed. The possibility to write your own sharelogger and simply plug it into PoolServerJ with a config file directive is nice. I implemented one that logs invalid shares to their own table (BTW: if "entry.reason == null && entry.ourResult" evaluates to true, is it safe to assume that this share is valid and should be counted for rewards?).
However I'd like to report a bug, or at least I think it is a bug.
I changed phoenix to do this:
Code:
if self.checkTarget(hash, nr.unit.target):
for bad in range(nonce, nonce+20):
formattedResult = pack('<76sI', nr.unit.data[:76], bad)
d = self.miner.connection.sendResult(formattedResult)
So when phoenix finds a share, it takes the nonce and submits it, but then increases the nonce by 1 and submits that "share" as well, and then continues until it has reached nonce+20.for bad in range(nonce, nonce+20):
formattedResult = pack('<76sI', nr.unit.data[:76], bad)
d = self.miner.connection.sendResult(formattedResult)
I actually find 20 shares in my table when only one should be valid, and they all have "our_result == 1".
Maybe the problem is with Res.getEasyDifficultyTargetAsInteger()?