Post
Topic
Board Armory
Re: Armory 0.96.5 RC1
by
goatpig
on 24/11/2018, 18:17:51 UTC
I was going to submit a PR about the port thing and this involved building against the dev branch.

This doesn't seem to be possible using Ubuntu 18.04 apt-get to get dependencies.

In addition to the packages in the linux build instructions, I used the following.

Code:
sudo apt-get install libprotobuf-dev protobuf-compiler  python-websocket libwebsockets-dev libevent-dev

However, the libwebsockets-dev package in 18.04 (and 18.10) is not sufficiently advanced.

I get an error that "lws_fop_fd_t" due to not in the include file.  

This typedef doesn't appear in the libwebsockets.h include file until version 2.2.0.

In Ubuntu-18.04, apt-get uses version 2.0.3-3build1.

Even in Ubuntu-18.10, apt-get still uses version 2.0.3-3build1.

I realize that this is the dev branch and things aren't stable yet, but I thought I would flag this.  

Being able to build from source is an important feature for Armory.  If websockets 2.2 functionality is required, would it be directly included in the repo, like some of the other dependencies?

Dev is 0.97, if you gonna PR you should do it against the testing branch, with 0.96.5. If you want to build dev, you need to clone the libwebsockets repo, checkout v3.0.0 or higher, build it, then give that path to the configure script in this fashion:

Code:
./configure --with-own-lws=/my/path/to/lws

P.S:

The client in dev cannot speak to db, I have not updated that part yet. Considering dropping swig and moving to CFFI to ease to migration to py3.