Mate, first of all, you should try to achieve some good knowledge of trading then you can start your trading business with long-term trading because as a newbie short-term trading will be hard to make profits for you. So I recommend you for doing long-term trading.
Exactly before thinking of whether long term is suitable or short term, better to have a strong look over what you are up to with knowledge. Learn first, grip more concepts and then jump to next step.
Both short term and long term can make you a profitable trader but there are a lot of things to consider, the most important is the amount of capital and the time you are willing to spend. Everything can be positively done through a proper timing but since the market is getting more unpredictable, the more we should be smarter in order to meet our goal.