The halving effect will start from May 2019 when people start to accumulate. The price starts to rise and miners will also return increasing the difficulty as a result. Dec 2019 will certainly be a good time for bitcoin hodlers (better than it was in 2018)