The best time to buy ether should be when the price of ether is cheap and there is a positive sentiment as regards Ethereum developments and it's growth. The news of ethereum upgrade will cause price spike, buying ether when price is rising is a good timing!
This is probably one of the best moments in the cryptocurrency market in the last year when you can easily make money in a short time, Ethereum has attracted all the attention