Re: [ANN] [QRK] Quark | POW+POS | 0.10.6.3

Quote from: AggroHead on August 25, 2019, 11:19:05 AM

no more wallet crashes because no new block syncs Undecided

in debug.log you find

Code:

Treasury payment of 106391.232 to QVvYypXoiRXcJpJpRVkftKEjMkXbd6UKJv

same issue as last time...

is it possible to manually correct blocktemplate to mine new correct block?

Quote from: PromethiumX on July 10, 2019, 02:13:36 PM

Quote from: Tpf0505 on July 10, 2019, 12:48:55 PM

Quote from: ghzsymc2 on July 10, 2019, 12:20:45 PM

Quote from: Tpf0505 on July 10, 2019, 09:46:28 AM

rpc-getblocktemplate calls CreateNewBlock()
(https://github.com/quark-project/quark/blob/f813e83ee229d9dce9f798051f96ca73f36d91f5/src/rpcmining.cpp#L517)

in CreateNewBlock() after MN-startblock it calls FillBlockPayee()
(https://github.com/quark-project/quark/blob/f813e83ee229d9dce9f798051f96ca73f36d91f5/src/miner.cpp#L360)

where FillTreasuryPayee() is called
(https://github.com/quark-project/quark/blob/f813e83ee229d9dce9f798051f96ca73f36d91f5/src/masternode-payments.cpp#L304)

Two possibilities

Some people are using the new code to generate a lot of rewards for the foundation
(to create panic)

Unknown bugs have emerged as a result of mining along with the old chain during the upgrade

it's a bug - happened during adaption of yiimp-base pool to new coinbase-layout.

getblocktemplate reports wrong scaled values and wallet doesn't check max value for treasury

Yeah! can we get a max value check? Better an error than a 27million coin overrun.
Any Idea where it's getting that magical number? (106,394.92616)

8 hours in seconds is 28800 times the MN reward 3.69416 is very close to the magical number 106391.808 Perhaps some rounding is involved.

QVvYypXoiRXcJpJpRVkftKEjMkXbd6UKJv
106,391.232 QRK
QirdV1H3Tikg12QefVkoFKrwkfHxT8EXia
3.69416 QRK

It's nice that we know the mistake now. But it's not nice that the bug occurs repeatedly and nobody from the developers here gives information.