Both of them has their pros and cons. Crypto and forex both represent a digital store of value and can be purchased and sold with ease. They both have high volatility which creates an opportunity for quick profits going long or short. Forex trading is more stable, but skilled traders can make much higher profits in crypto.
Forex trading is not digital store of value. It is a digital representation of the store of value of currencies used in real world. It is affected by many more factors than cryptocurrencies like country's economic situation, Balance of Payments, International Trade, etc.