Totally a matter of personal preference. If someone is a bit lazy but clever one, he should go with long term trading. That will save him the trouble of checking the changing prices every other moment. However, his holding must be a potential one like bitcoin so that his wait will not become a waste eventually. Short term trading is the better one and hectic one too. Within short time, trader can earn more.
You can earn more if you are a short term trader but you can lose more as well, short term trading is by far the most difficult way to trade and yet it is the most popular amongst newbies and that is definitely a problem, it is better in this market to start your journey in a slow way and only try long term trades and you can change this once you have corroborated you can be successful, but very few try this approach and eventually suffer the consequences of not doing so.
Short term trading needs also more expertise in trading and demands higher risks because if you trade with the wrong time, you will only lose your money in just a sudden. While long term trading has less risks and is stress free because you will still get profits just by sitting in your chair waiting for your coins to increase its price. No need to monitor daily the price charts just like what a short term trader should do.