There are different types of wallets out there. People mostly use desktop, mobile, online and hardware wallets.
Online wallets on reliable services are fine for relatively small amounts if you use 2FA security layer properly. But you should remember to
check url when visiting online wallets - many fishing sites out there.
Desktop and mobile wallets are also ok if you know associated threats and security measures.
If you are going to keep significant bitcoin long-term, then hardware wallet is a must. There are many manufacturers, including Trezor, Ledger, Keepkey, Bitbox etc. Trezor is the oldest company. Ledger and Trezor are most popular.
I don't know other types of wallets apart from hardware wallets that can gives me confidence that I actually OWN my bitcoins. I've lost some assets on 2 exchanges due to hacker attacks. One of them was Cryptopia. I didn't have any problems with desktop wallets, but I know something about security.
Here is a simple guide:
https://bitcoins.menu/#bitcoin-wallets-easily-explained