This has been asked many times in the past and in my opinion the same answer always applies, the best is whichever fits your personality and can produce for you the most profits, for example you may want to be come a day trader but if you work 12 hours per day and you have a family to attend you are not going to have the time to become either a day trader or a scalper, you need to become a swing trader or even a position trader.

In the other hand you may like to hold your positions for months or even years but if you are impatient then that style of trading is not going to fit you so it is better for you to become a day trader or a scalper, as you can see the decision of what trader to become comes down at the end to your particular circumstances and your ability to profit from those circumstances.