Even if you do not give out your private carelessly, simply making silly mistake by connecting your network to phishing WiFi results to the lost of your bitcoin by scammers who search in your device looking for your private keys, so you can win the hackers by storing your funds offline as this is the best way of keeping your secret keys.
indeed many have experienced things that are not wearing with the use of a wallet, but from many situations that I have seen, it is all due to the person's personal error so that the private key can be hacked, compared to the weakness of the wallet. because I feel that what has been made because it is based on security is acclaimed very good.
but when compared to offline wallets, it is clear that you can't compare anymore because offline ones are certainly more secure and can be recognized for their security so far.
but there are still many of us who can't go offline because they are constrained by costs.