Ledger
has already ceased the production of the Nano S. You can still order [ur=https://shop.ledger.com/products/ledger-nano-s-final-edition]the "Final Edition" limited edition[/url].
Does this also mean anyone that has a nano ledger s would eventually need to get a nano ledger s plus or x in the future? I know lot of people from years back bought the nano ledger s and store their coins there. But is there any concern now that because this product is discontinued, it won't work later on in the future such as there won't be any firmware updates for it anymore?
Ledger might stop providing software updates at some point in the future. No one knows when that's going to happen. You will always be able to use your device with older versions of Ledger Live and Electrum.
Do you recommend everyone with just a nano ledger s now buy another hardware wallet such as the nano s plus or the x and just input their seed phrase into the new hardware wallet and no longer use the nano ledger s anymore or there is absolutely no need for that now?
Why would you replace it if it's still functional? By the time the Nano S becomes unsupported, there might be a ton of new hardware wallets to choose from.