Could you briefly tell us about the advantages of silent payments over the common xpub sharing technique?
But the summary is: you should share your xpub only with those you are confident sharing your privacy with, as they would be able to track all your received payments scanning the addresses generated from such xpub.
Silent payments instead break this allowing you the total privacy (with the “scanning costs”).
Sharing an xpub is also a security risk, due to being able to derive all private keys from an xpub and a single private key.
If, and only if, the recipient also obtains a single private key from your wallet, the recipient can obtain all your private keys and steal your funds, just as if they had your xprv key.