There's nothing wrong with cold storages but you could have opted in for bitcoincore preferably, but the option of choosing a cold storage like electrum wallet is a very good idea along with the hardware wallets (ledger nano and trezor) as you've mentioned and you will need to ensure that you have a good and secured means that xan handle the safety of your keys if using (electrum) and where to safe keep your hardware wallet if using (ledger nano or trezor) agaist damage, lost or stolen from external constraints.