Post
Topic
Board Project Development
Re: Keyhunt - development requests - bug reports
by
albert0bsd
on 28/04/2023, 13:23:30 UTC
Maybe albert0bsd refer to bug of using -m address (single, NOT -m addresses ) which will miss the key.

Not is not that, the bloom filter that he is using have some bugs i report those bugs to the developer of the bloomfilter

https://github.com/jvirkki/libbloom/issues/20

But the developer update it some year before that, i solve by my own implementation.

I notify to KV but he didn't solve as far i can remember

So for small list of address it work fime, but for bigger lists it can fail.

I updated my bloom filter implementation to use xxhash (64 bits) instead of murmurhash (32bits), because with murmurhash if the number of addresses in the list, is near to 32 bits then the bloom may be some saturated because almost any data tha that you pass to the bloom filter will do a collision.

Look the original code in https://github.com/jvirkki/libbloom/blob/master/bloom.c#L57

With a 64 bit hash the problem will be solved, but the original bloom may never change it because compatibility reasons.

the KV version may have some other bugs but since it was some kind of copy of my keyhunt, i prefer to improve my own version than fix another versions.