For long term hold, hardware wallets are surely the best especially when you will not need to be accessing the wallet every now and then. However, you must put extra care to protect the physical wallet just like you will protect your gold wrist watch or expensive jewelry. Trezor Model T and Ledger Nano X are good cold storage wallets.

For wallets you will access regularly,  Exodus and Electrum are good hot wallets with the former very good for beginners and the later for advanced users.