Well, I'm going to say that quitting smoking could really help you to save your money while also having a good health, killing two birds in one stone.
But it is not true to everybody. Some people who give advice to quit smoking so you could save up to buy a car, a house, or something else, then you'll ask them if they smoke, they'll answer "No", and then you'll ask them "do you have a car now since you don't smoke?" Most of them will answer "No, I don't have any" which helps you realized that whether a certain person smoke or not, if he doesn't know how to handle money, he can't buy anything because he can't save any amount.
In short, you can have any vices and still save at the same time, buying anything you want, investing in anything you want. It's all about how you handle your finances, and of course don't just rely on just one source of income.